[CIR][link-builtin-code] This PR adds support to link in bytecodes on CC1. #2010
+118
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koparasy
changed the title
koparasy
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
bcardosolopes
approved these changes
Nov 25, 2025
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Thanks for working on this. I agree that we shouldn't be duplicating it.
Probably the best we can do right now is to send the same PR upstream, so we can bikeshed over there and if someone has a smarter idea we can backport it.
In the meantime it's acceptable in the incubator because we don't want to fiddle with OG in this repo. Would you mind sending a similar PR for this upstream?
LGTM after some nits
Contributor
Author
|
I will do a PR at upstream as well over the next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bcardosolopes I need some advice here. Is this a valid direction, do I respect sufficiently the original driver? If not, any pointers?