[CIR] Remove explicit checks of function attributes in unrelated tests #2027
+1,088
−967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
xlauko
force-pushed
the
users/xlauko/simplify-function-attribute-checks
branch
from
9e47299 to
b292185
Compare
bcardosolopes
approved these changes
Nov 26, 2025
xlauko
force-pushed
the
users/xlauko/simplify-function-attribute-checks
branch
from
b292185 to
48cffd8
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
xlauko
force-pushed
the
users/xlauko/simplify-function-attribute-checks
branch
from
48cffd8 to
9d0a784
Compare
xlauko
force-pushed
the
users/xlauko/simplify-function-attribute-checks
branch
from
9d0a784 to
81c46ae
Compare
This will simplify transition to other explicit attributes from extra attrs.
xlauko
force-pushed
the
users/xlauko/simplify-function-attribute-checks
branch
from
81c46ae to
82422eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the transition to explicit attributes by removing the need to update tests that don’t care about every individual attribute. Only the tests that are specifically intended to check those attributes still use explicit attribute checks.