This repository was archived by the owner on Feb 21, 2026. It is now read-only.
[CIR][AMDGPU] Add AMDGPU-specific function attributes for HIP/OpenCL kernels#2091
Merged
[CIR][AMDGPU] Add AMDGPU-specific function attributes for HIP/OpenCL kernels#2091
Conversation
skc7
force-pushed
the
skc7/cir_attr_amdgpu
branch
from
6f043a2 to
b0994ce
Compare
skc7
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
Collaborator
Author
|
All the attributes lowered in this PR are amdgpu llvm backend specific and I think CIR need not have a separate attribute for them at HIP level, (which prevents leakage of LLVM specific things into CIR). |
Member
Member
|
@skc7 seems like some conflict resolution is needed |
skc7
force-pushed
the
skc7/cir_attr_amdgpu
branch
from
b0994ce to
bf404ea
Compare
bcardosolopes
approved these changes
Jan 16, 2026
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Ready to land once conflict is fixed
skc7
force-pushed
the
skc7/cir_attr_amdgpu
branch
from
32ef483 to
3660fd5
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Contributor
|
Sorry I missed this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for AMDGPU-specific function attributes for HIP/OpenCL kernels
setTargetAttributesforAMDGPUTargetCIRGenInfoto set kernel attributesamendFunctionto translate string-valued extra function attributes to LLVM function attributesFollows OGCG AMDGPU implementation from "clang/lib/CodeGen/Targets/AMDGPU.cpp".