[eudsl-tblgen] add lots of stuff (support retrieving ArgumentInits from Record) #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a niche PR so I don't expect anyone to really closely review but I'm describing it anyway just to capture some findings.
The basic feature added in this PR is the ability to recover from an instantiated
defwhich template args were used in theclasscall/invocation/thing. E.g.,With this PR you can recover that the
mnemonicpassed as the first argument toTest_Opwhen instantiatingTest_AndOpis"and". This sounds like something that should've been always possible but turns out tablegen literally doesn't keep that information in any way/shape/form. In order to make this work I had to hack the parser to keep it around (note, this isn't completely straightforward because arguments can have unevaluated bang operators).For context, I intended on using this functionality to translate LLVM
Intrinsics into MLIR OpDefs but turns out it didn't really work out (not because the feature doesn't work but because I have ~30kIntrinsics lol).