std::terminate() is being called when std::bad_exception should be thrown

[llvmbot]

Bugzilla Link	10541
Resolution	FIXED
Resolved on	Nov 10, 2012 13:26
Version	unspecified
OS	MacOS X
Attachments	complete program exhibiting the error
Reporter	LLVM Bugzilla Contributor

Extended Description

I have a program with a function 'foo' that lists std::bad_exception in its exception specification, and a custom unexpected hander is registered which rethrows an exception. When 'foo' is called it throws a type not listed and so my custom unexpected handler is called. However, if I'm using libc++ then after my handler is called std::terminate() is called.

These circumstances should lead to std::bad_exception being thrown and exception handling continuing normally instead of std::terminate() being called.

[llvmbot]

fix missing cxa_end_catch
Hi all,

I've done this patch for a simple fix.
Please help verify and review it.

Thanks.

[llvmbot]

Hi all,

Sorry that this patch is wrong, please just ignore it.

In my experimental result, I think this bug didn't occur in libc++abi.
I guess, you are using libc++ and libc++abi now.

If you comment out the std::cerr line, you will discover that everything works.
Also, if you replace std::cerr by fprintf, and totally remove the command line flag libstdc++, libgcc nor libc++, just manually add -lcxxabi, and you will find that everything works again!

I think we should file another bug into libc++ project.

BTW, I will change the status.
Please re-open and forgive me if I should not do that. :)
Thanks.

Created attachment 9521 [details]
fix missing cxa_end_catch

Hi all,

I've done this patch for a simple fix.
Please help verify and review it.

Thanks.

[llvmbot]

Yes, this issue does seem to have been fixed. Looks like it happened in January this year, commit r149251 / 7da9b96afc66c44.