[Formatter/ObjC] In ObjC dict literals, breaking after ',' should be preferred over breaking before ':'

[nico]

Bugzilla Link	15230
Resolution	FIXED
Resolved on	May 26, 2013 01:21
Version	unspecified
OS	All

Extended Description

return @{
kTitleKey: title,
kIsGroupItemKey: [NSNumber numberWithBool:isGroupItem],
kChildrenKey: children,
kCanExpandKey: [NSNumber numberWithBool:canExpand]
};

is formatted as

return @{ kTitleKey : title, kIsGroupItemKey
: [NSNumber numberWithBool:isGroupItem], kChildrenKey : children,
kCanExpandKey : [NSNumber numberWithBool:canExpand] };

Better would be

return @{ kTitleKey : title,
kIsGroupItemKey : [NSNumber numberWithBool:isGroupItem],
kChildrenKey : children,
kCanExpandKey : [NSNumber numberWithBool:canExpand] };

(Possibly even better: The original formatting.)

Note to self: The fix probably involves adding a "ColonIsObjCDictKeySeparator" bool, setting that in parseBraces() if parent is '@', giving ':' a TT_ObjCKeySeparator token type, and then assigning a fairly high splitPenalty() to tokens with type TT_ObjCKeySeparator.

[nico]

This specific problem was apparently fixed by r182716. There's more work to be done for dict literals, but this bug is fixed I think.