[clang] Rename some variables with stale names

[localspook]

Commit bcd0350 renamed DeclaratorInfo to TypeSourceInfo. This left behind some cases like:

llvm-project/clang/lib/Sema/SemaTemplate.cpp

Line 952 in 66b4815

TypeSourceInfo *DI;

Where the variable name is now meaningless. I was quite confused the first time I stumbled into one of these. These variables should be renamed; something simple like replacing DI with TSI will work just fine.

Doing a

git grep -n 'TypeSourceInfo.*DI'

should find most of them (I see 33 hits running it locally).

Note: if you want to take on this issue, it's a good idea to post a comment saying you're looking into it, but you don't need to wait for anyone's approval to get started; just go for it!

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Victor Chernyakin (localspook)

Commit bcd0350 renamed `DeclaratorInfo` to `TypeSourceInfo`. This left behind some cases like: https://github.com/llvm/llvm-project/blob/66b481556e01e6e2508d7c9146849167b9e0323f/clang/lib/Sema/SemaTemplate.cpp#L952 Where the variable name is now meaningless. I was quite confused the first time I stumbled into one of these. These variables should be renamed; something simple like replacing `DI` with `TSI` will work just fine.

Doing a

git grep -n 'TypeSourceInfo.*DI'

should find most of them (I see 33 hits running it locally).

Note: if you want to take on this issue, it's a good idea to post a comment saying you're looking into it, but you don't need to wait for anyone's approval to get started; just go for it!

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor is working on this issue. If someone is assigned to the issue or claimed to be working on it, ping the person. After one week without a response, the assignee may be changed.
2. Leave a comment indicating that you are working on the issue, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Victor Chernyakin (localspook)

Commit bcd0350 renamed `DeclaratorInfo` to `TypeSourceInfo`. This left behind some cases like: https://github.com/llvm/llvm-project/blob/66b481556e01e6e2508d7c9146849167b9e0323f/clang/lib/Sema/SemaTemplate.cpp#L952 Where the variable name is now meaningless. I was quite confused the first time I stumbled into one of these. These variables should be renamed; something simple like replacing `DI` with `TSI` will work just fine.

Doing a

git grep -n 'TypeSourceInfo.*DI'

should find most of them (I see 33 hits running it locally).

Note: if you want to take on this issue, it's a good idea to post a comment saying you're looking into it, but you don't need to wait for anyone's approval to get started; just go for it!

[teddygood]

Hi, can I get assigned to this?