[BOLT] Crash when calling setIgnored on multiple threads

[bgergely0]

setIgnored() is called concurrently in bolt/lib/Passes/MarkRAStates.cpp.

Details

setIgnored() calls scanExternalRefs, which calls BC.SymbolicDisAsm->setSymbolizer to set a BinaryFunction-specific symbolizer, therefore making calling setIgnored from multiple threads operating on individual BinaryFunctions unsafe.

setIgnored also calls clearDisasmState, which writes to BC.UndefinedSymbols, making concurrent access unsafe again.

[llvmbot]

@llvm/issue-subscribers-bolt

Author: Gergely Bálint (bgergely0)

`setIgnored()` is called concurrently in `bolt/lib/Passes/MarkRAStates.cpp`.

Details

setIgnored() calls scanExternalRefs, which calls BC.SymbolicDisAsm->setSymbolizer to set a BinaryFunction-specific symbolizer, therefore making calling setIgnored from multiple threads operating on individual BinaryFunctions unsafe.

setIgnored also calls clearDisasmState, which writes to BC.UndefinedSymbols, making concurrent access unsafe again.

[llvmbot]

@llvm/issue-subscribers-bug

Author: Gergely Bálint (bgergely0)

`setIgnored()` is called concurrently in `bolt/lib/Passes/MarkRAStates.cpp`.

Details

setIgnored() calls scanExternalRefs, which calls BC.SymbolicDisAsm->setSymbolizer to set a BinaryFunction-specific symbolizer, therefore making calling setIgnored from multiple threads operating on individual BinaryFunctions unsafe.

setIgnored also calls clearDisasmState, which writes to BC.UndefinedSymbols, making concurrent access unsafe again.