LLDB shouldn't show inline diagnostics for things that aren't visible

[JDevlieghere]

For example, when I add settings set target.run-args -foo to my ~/.lldbinit, I see this when I launch LLDB:

❯ lldb
                                    ˄˜˜˜
                                    ╰─ error: unknown or ambiguous option

We still want to see an error if the command failed, just not by pointing to nothing.

❯ lldb
error: unknown or ambiguous option

That's still not great, but it would match our existing behavior of showing the command output. For example, this is what you see when you set an invalid option in your ~/.lldbinit:

❯ lldb
"foo" is not a valid subcommand of "settings". Valid subcommands are: append, clear, insert-after, insert-before, list, and others. Use "help settings" to find out more.

We could improve both by printing the command if it failed, even when echoing is off. That way we don't need to change the inline diagnostics at all.

[llvmbot]

@llvm/issue-subscribers-lldb

Author: Jonas Devlieghere (JDevlieghere)

For example, when I add `settings set target.run-args -foo` to my `~/.lldbinit`, I see this when I launch LLDB:

❯ lldb
                                    ˄˜˜˜
                                    ╰─ error: unknown or ambiguous option

We still want to see an error if the command failed, just not by pointing to nothing.

❯ lldb
error: unknown or ambiguous option

That's still not great, but it would match our existing behavior of showing the command output. For example, this is what you see when you set an invalid option in your ~/.lldbinit:

❯ lldb
"foo" is not a valid subcommand of "settings". Valid subcommands are: append, clear, insert-after, insert-before, list, and others. Use "help settings" to find out more.

We could improve both by still printing the command if it failed. That way we don't need to change the inline diagnostics.