gvn aborts in testcase with sret

[sunfishcode]

Bugzilla Link	2087
Resolution	FIXED
Resolved on	Feb 24, 2008 18:41
Version	trunk
OS	MacOS X
Attachments	bugpoint-reduced testcase from 252.eon

Extended Description

Running opt -gvn on the attached testcase aborts:

Instruction does not dominate all uses!
%tmp1.i = getelementptr %struct.ggFrame3* %agg.result, i32 0, i32 1 ; <%struct.ggONB3*> [#uses=2]
call void @​_ZN12ggQuaternion7getONB3Ev( %struct.ggONB3* noalias sret %tmp1.i, %struct.ggQuaternion* %qresult ) nounwind
Broken module found, compilation aborted!

This is a bugpoint-reduced testcase from 252.eon.

[llvmbot]

The simple solution is to check that the new operand dominates the memcpy before making the transformation. A more complicated solution would involve rematerializing the operand (if possible). I suspect the first choice is the appropriate one. ;-)

[llvmbot]

Fixed in r47541.