test/lib/llvm.exp uses wrong substitution order

[llvmbot]

Bugzilla Link	2120
Resolution	FIXED
Resolved on	Mar 06, 2010 13:59
Version	2.2
OS	Linux
Blocks	llvm/llvm-bugzilla-archive#2121
Attachments	Replacement order reversal
Reporter	LLVM Bugzilla Contributor

Extended Description

When replacing command names from site.exp, the code first replaces %compile_c, then %compile_cxx, but it will never find %compile_cxx since its prefix %compile_c was already replaced.

Fix: revert the replacement order.

(Note on severity: inconsequential right now since the %compile_* macros aren't used in test/, but the bug fix I'm about to report next will depend on this.)

[lattner]

Makes sense, patch looks great, applied:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080310/059425.html

Thanks!

[llvmbot]

mentioned in issue llvm/llvm-bugzilla-archive#2121