Handle special cases in AArch64InstrInfo::GetInstSizeInBytes

[rovka]

Bugzilla Link	28750
Version	trunk
OS	Linux
CC	@rengolin

Extended Description

This function tends to return 4 for just about any instruction. This isn't always the case (see #24608 ).

Looking through AArch64AsmPrinter, it seems STACKMAP and PATCHPOINT may need special handling. The heuristic for inline asm may also need to be brushed up a bit.

[rovka]

Stackmap / patchpoint proposed patch: https://reviews.llvm.org/D24073

[c-rhodes]

@rovka can be closed now?

[c-rhodes]

This function tends to return 4 for just about any instruction. This isn't always the case (see #24608 ).

Looking through AArch64AsmPrinter, it seems STACKMAP and PATCHPOINT may need special handling.

I had a look and STACKMAP and PATCHPOINT are now handled. The function in question has changed a fair bit since this issue was created, there are more opcodes with variable size that have special handling now and it also checks if size is set in TableGen before returning 4.

The heuristic for inline asm may also need to be brushed up a bit.

Without more info I think this can be closed.