missing implicit promotion (array -> pointer) in objc messages

[llvmbot]

Bugzilla Link	2997
Resolution	FIXED
Resolved on	Mar 12, 2010 00:57
Version	unspecified
OS	All
Reporter	LLVM Bugzilla Contributor
CC	@lattner,@efriedma-quic,@tkremenek

Extended Description

From running 120, here's a crash report for you.

[llvmbot]

Get the crash reports at http://dan.karelia.com/drop/crashes.zip

[tkremenek]

The error is from the semantic analyzer:

/Volumes/dwood/Subversion/connection/trunk/SFTPTServer.m:98:10: error: cannot modify value of type 'char *[]'
prompts++;
~~~~~~~^

Looks like a missing promotion from 'char *[]' to 'char **'.

[tkremenek]

BTW, running clang -fsyntax-only on the attached .mi file (in the zip) reproduces this error.

[llvmbot]

I'll take care of this...

[tkremenek]

I just verified with TOT (60573) that we are still seeing this bug:

$ clang clang_crash_7VAgic.clang.mi
clang_crash_7VAgic.clang.mi:138866:10: error: cannot modify value of type 'char *[]'
prompts++;

1 diagnostic generated.

I don't know why this should be marked 'FIXED'.

[tkremenek]

I misread bugzilla; this PR is not marked fixed.

[lattner]

This is rdar://6424064

[llvmbot]

Fixed in http://llvm.org/viewvc/llvm-project?view=rev&revision=60781.

Sorry for the delay!

[lattner]

Thanks Steve!