cmake should use globbing rather than listing all files in CMakeLists.txt

[llvmbot]

Bugzilla Link	4527
Resolution	WONTFIX
Resolved on	Feb 22, 2010 12:53
Version	trunk
OS	Linux
Reporter	LLVM Bugzilla Contributor
CC	@oscarfv

Extended Description

Every time someone adds a new .cpp file, the cmake build breaks because
they inevitably forget to add the file to CMakeLists.txt. In almost all
LLVM directories you want to build all .cpp files in it, so it seems silly
to have to list all files in CMakeLists.txt rather than doing something
like "*.cpp".

[llvmbot]

No it shouldn't. Using globs instead of listing all files breaks proper dependency generation. New files still won't be picked up by "make", unless you also run "cmake" before running make, which is why hardly any CMake-using projects use globs.

As far as I remember CMake documentation discouraged using globs for this, but I can't find the source for this atm.

[oscarfv]

For the reason mentioned on comment #​1, this will not be implemented. The feature was discussed and rejected on the mailing list, at the time when the cmake build system was in its early development.

[llvmbot]

Since the CMakeLists.txt files are simply listing all the files in the
current directory, it is silly to have to keep them up to date by hand.
It should be automated - this is the fundamental point. Whether it is
automated by doing globbing inside the file, or running some script that
creates these files or some other solution doesn't matter much - a solution
is needed. What do you suggest?