Clang complains about attributes post-definition

[llvmbot]

Bugzilla Link	6361
Resolution	FIXED
Resolved on	Sep 23, 2013 17:15
Version	trunk
OS	Windows NT
Blocks	llvm/llvm-bugzilla-archive#6815 llvm/llvm-bugzilla-archive#10638
Reporter	LLVM Bugzilla Contributor
CC	@rnk

Extended Description

Here's a testcase :

void a(){}
void __cdecl a();

Clang emits a warning, but there is no way to disable it.

[llvmbot]

Like I was saying on IRC, the real bug is not that there's no flag controlling this, but that clang is warning at all.

The __cdecl calling convention is the default, so clang should not be warning when a function declared without a calling convention is redeclared as cdecl (or whatever the default is).

[llvmbot]

Fixed. Fix committed as r96895.

[llvmbot]

Tested with clang r100910, issue still exists.

testcase.c(2) : warning: attribute declaration must precede definition
void __cdecl a();
^
testcase.c(1) : note: previous definition is here
void a(){}
^

[llvmbot]

I thought about adding a special case for __cdecl, but I decided against it. It seems like a hack, and I'm sure Doug and John would agree with me.

The "proper" way to fix this would be to allow attributes post-definition. Doug, John, are you OK with me removing it? Or is there a good reason it's still there?

[llvmbot]

This seems to be fixed in 3.3. Amine, could you retest?

[rnk]

This doesn't warn for me locally. The checks that used to avoid warning in this case were removed in the transition from CC_Default to CC_C.

[llvmbot]

mentioned in issue llvm/llvm-bugzilla-archive#6815