Skip to content

[clang-tidy][use-internal-linkage] fix false positive for consteval function #122141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

[clang-tidy][use-internal-linkage] fix false positive for consteval function #122141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92e1753
[clang-tidy][use-internal-linkage] fix false positive for consteval f…
Jan 8, 2025
ac7bf31
constexpr
Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang-tools-extra/clang-tidy/misc/UseInternalLinkageCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ void UseInternalLinkageCheck::registerMatchers(MatchFinder *Finder) {
exportDecl()))))));
Finder->addMatcher(
functionDecl(Common, hasBody(),
unless(anyOf(cxxMethodDecl(),
unless(anyOf(cxxMethodDecl(), isConsteval(),
isAllocationOrDeallocationOverloadedFunction(),
isMain())))
.bind("fn"),
Expand Down
6 changes: 3 additions & 3 deletions clang-tools-extra/docs/ReleaseNotes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,9 +286,9 @@ Changes in existing checks

- Improved :doc:`misc-use-internal-linkage
<clang-tidy/checks/misc/use-internal-linkage>` check to insert ``static``
keyword before type qualifiers such as ``const`` and ``volatile`` and fix
false positives for function declaration without body and fix false positives
for C++20 export declarations and fix false positives for global scoped
keyword before type qualifiers such as ``const`` and ``volatile``. Also, fix
false positives for function declaration without body, C++20 consteval
functions, C++20 export declarations, and global scoped
overloaded ``operator new`` and ``operator delete``.

- Improved :doc:`modernize-avoid-c-arrays
Expand Down
7 changes: 7 additions & 0 deletions clang-tools-extra/test/clang-tidy/checkers/misc/use-internal-linkage-consteval.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// RUN: %check_clang_tidy -std=c++20 %s misc-use-internal-linkage %t -- -- -I%S/Inputs/use-internal-linkage

consteval void gh122096() {}
Copy link
Member

@chfast chfast Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also check constexpr void func_constexpr()?

Copy link
Contributor Author

@maflcko maflcko Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, added


constexpr void cxf() {}
// CHECK-MESSAGES: :[[@LINE-1]]:16: warning: function 'cxf'
// CHECK-FIXES: static constexpr void cxf() {}
Loading