Skip to content

[BPF] Emit proper error message for insns with tied operands #146778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

[BPF] Emit proper error message for insns with tied operands #146778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions llvm/lib/Target/BPF/AsmParser/BPFAsmParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,9 @@ bool BPFAsmParser::matchAndEmitInstruction(SMLoc IDLoc, unsigned &Opcode,
case Match_InvalidSImm16:
return Error(Operands[ErrorInfo]->getStartLoc(),
"operand is not a 16-bit signed integer");
case Match_InvalidTiedOperand:
return Error(Operands[ErrorInfo]->getStartLoc(),
"operand is not the same as the dst register");
}

llvm_unreachable("Unknown match type detected!");
Expand Down
12 changes: 12 additions & 0 deletions llvm/test/MC/BPF/bad-tied.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# RUN: not llvm-mc -mcpu=v4 -triple bpfel < %s 2>&1 \
# RUN: | grep 'error: operand is not the same as the dst register' \
# RUN: | count 9
r0 = bswap16 r1
r0 = bswap32 r1
r0 = bswap64 r1
r0 = atomic_fetch_add((u64*)(r2 + 0), r1)
r0 = atomic_fetch_and((u64*)(r2 + 0), r1)
r0 = atomic_fetch_or((u64*)(r2 + 0), r1)
r0 = atomic_fetch_xor((u64*)(r2 + 0), r1)
w0 = xchg32_32(r2 + 0, w1)
r0 = xchg_64(r2 + 0, r1)
Loading