Skip to content

[mlir] Deprecate OpPrintingFlags(std::nullopt_t) (NFC) #149546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazutakahirata merged 1 commit into from
Jul 18, 2025
Merged

[mlir] Deprecate OpPrintingFlags(std::nullopt_t) (NFC) #149546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/include/mlir/IR/OpDefinition.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class OpState {
MLIRContext *getContext() { return getOperation()->getContext(); }

/// Print the operation to the given stream.
void print(raw_ostream &os, OpPrintingFlags flags = std::nullopt) {
void print(raw_ostream &os, OpPrintingFlags flags = {}) {
state->print(os, flags);
}
void print(raw_ostream &os, AsmState &asmState) {
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/IR/Operation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ class alignas(8) Operation final
/// take O(N) where N is the number of operations within the parent block.
bool isBeforeInBlock(Operation *other);

void print(raw_ostream &os, const OpPrintingFlags &flags = std::nullopt);
void print(raw_ostream &os, const OpPrintingFlags &flags = {});
void print(raw_ostream &os, AsmState &state);
void dump();

Expand Down
1 change: 1 addition & 0 deletions mlir/include/mlir/IR/OperationSupport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1175,6 +1175,7 @@ class alignas(8) OperandStorage {
class OpPrintingFlags {
public:
OpPrintingFlags();
LLVM_DEPRECATED("Use OpPrintingFlags() instead", "OpPrintingFlags()")
OpPrintingFlags(std::nullopt_t) : OpPrintingFlags() {}

/// Enables the elision of large elements attributes by printing a lexically
Expand Down
Loading