Skip to content

[orc-rt] Fix byteswap implementation for 64-bit types, rename tests. #157074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
Merged

[orc-rt] Fix byteswap implementation for 64-bit types, rename tests. #157074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions orc-rt/include/orc-rt/bit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ template <typename T, typename = std::enable_if_t<std::is_integral_v<T>>>
#elif defined(_MSC_VER) && !defined(_DEBUG)
return _byteswap_uint64(UV);
#else
uint64_t Hi = llvm::byteswap<uint32_t>(UV);
uint32_t Lo = llvm::byteswap<uint32_t>(UV >> 32);
uint64_t Hi = byteswap<uint32_t>(UV);
uint32_t Lo = byteswap<uint32_t>(UV >> 32);
return (Hi << 32) | Lo;
#endif
} else {
Expand Down
4 changes: 2 additions & 2 deletions orc-rt/unittests/bit-test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ TEST(BitTest, endian) {
#endif
}

TEST(MathTest, byte_swap_32) {
TEST(BitTest, byte_swap_32) {
unsigned char Seq[] = {0x01, 0x23, 0x45, 0x67};
uint32_t X = 0;
memcpy(&X, Seq, sizeof(X));
Expand All @@ -56,7 +56,7 @@ TEST(MathTest, byte_swap_32) {
#endif
}

TEST(MathTest, byte_swap_64) {
TEST(BitTest, byte_swap_64) {
unsigned char Seq[] = {0x01, 0x23, 0x45, 0x67, 0x89, 0xAB, 0xCD, 0xEF};
uint64_t X = 0;
memcpy(&X, Seq, sizeof(X));
Expand Down
Loading