Skip to content

Refactor ConvertAlloc #158081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −20
Draft

Refactor ConvertAlloc #158081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 5 additions & 20 deletions mlir/lib/Conversion/MemRefToEmitC/MemRefToEmitC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,24 +153,8 @@ struct ConvertAlloc final : public OpConversionPattern<memref::AllocOp> {
loc, "incompatible memref type for EmitC conversion");
}

Type sizeTType = emitc::SizeTType::get(rewriter.getContext());
Type elementType = memrefType.getElementType();
IndexType indexType = rewriter.getIndexType();
emitc::CallOpaqueOp sizeofElementOp = emitc::CallOpaqueOp::create(
rewriter, loc, sizeTType, rewriter.getStringAttr("sizeof"),
ValueRange{},
ArrayAttr::get(rewriter.getContext(), {TypeAttr::get(elementType)}));

int64_t numElements = 1;
for (int64_t dimSize : memrefType.getShape()) {
numElements *= dimSize;
}
Value numElementsValue = emitc::ConstantOp::create(
rewriter, loc, indexType, rewriter.getIndexAttr(numElements));

Value totalSizeBytes =
emitc::MulOp::create(rewriter, loc, sizeTType,
sizeofElementOp.getResult(0), numElementsValue);
calculateMemrefTotalSizeBytes(loc, memrefType, rewriter);

emitc::CallOpaqueOp allocCall;
StringAttr allocFunctionName;
Expand All @@ -179,8 +163,8 @@ struct ConvertAlloc final : public OpConversionPattern<memref::AllocOp> {
if (allocOp.getAlignment()) {
allocFunctionName = rewriter.getStringAttr(alignedAllocFunctionName);
alignmentValue = emitc::ConstantOp::create(
rewriter, loc, sizeTType,
rewriter.getIntegerAttr(indexType,
rewriter, loc, emitc::SizeTType::get(rewriter.getContext()),
rewriter.getIntegerAttr(rewriter.getIndexType(),
allocOp.getAlignment().value_or(0)));
argsVec.push_back(alignmentValue);
} else {
Expand All @@ -196,7 +180,8 @@ struct ConvertAlloc final : public OpConversionPattern<memref::AllocOp> {
emitc::OpaqueType::get(rewriter.getContext(), "void")),
allocFunctionName, args);

emitc::PointerType targetPointerType = emitc::PointerType::get(elementType);
emitc::PointerType targetPointerType =
emitc::PointerType::get(memrefType.getElementType());
emitc::CastOp castOp = emitc::CastOp::create(
rewriter, loc, targetPointerType, allocCall.getResult(0));

Expand Down