Skip to content

[alpha.webkit.RetainPtrCtorAdoptChecker] Don't treat assignment to an +1 out argument as a leak #161633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[alpha.webkit.RetainPtrCtorAdoptChecker] Don't treat assignment to an +1 out argument as a leak #161633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions clang/lib/StaticAnalyzer/Checkers/WebKit/RetainPtrCtorAdoptChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,14 +355,30 @@ class RetainPtrCtorAdoptChecker
void visitBinaryOperator(const BinaryOperator *BO) const {
if (!BO->isAssignmentOp())
return;
if (!isa<ObjCIvarRefExpr>(BO->getLHS()))
return;
auto *LHS = BO->getLHS();
auto *RHS = BO->getRHS()->IgnoreParenCasts();
const Expr *Inner = nullptr;
if (isAllocInit(RHS, &Inner)) {
CreateOrCopyFnCall.insert(RHS);
if (Inner)
CreateOrCopyFnCall.insert(Inner);
if (isa<ObjCIvarRefExpr>(LHS)) {
const Expr *Inner = nullptr;
if (isAllocInit(RHS, &Inner)) {
CreateOrCopyFnCall.insert(RHS);
if (Inner)
CreateOrCopyFnCall.insert(Inner);
}
return;
} else if (auto *UO = dyn_cast<UnaryOperator>(LHS)) {
auto OpCode = UO->getOpcode();
if (OpCode == UO_Deref) {
if (auto *DerefTarget = UO->getSubExpr()) {
DerefTarget = DerefTarget->IgnoreParenCasts();
auto *DRE = dyn_cast<DeclRefExpr>(DerefTarget);
if (auto *Decl = DRE->getDecl()) {
if (!isa<ParmVarDecl>(Decl) || !isCreateOrCopy(RHS))
return;
if (Decl->hasAttr<CFReturnsRetainedAttr>())
CreateOrCopyFnCall.insert(RHS);
}
}
}
}
}

Expand Down
8 changes: 8 additions & 0 deletions clang/test/Analysis/Checkers/WebKit/retain-ptr-ctor-adopt-use.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,14 @@ void adopt_retainptr() {
auto bar = adoptNS([allocSomeObj() init]);
}

CFTypeRef make_cf_obj() CF_RETURNS_RETAINED {
return CFArrayCreateMutable(kCFAllocatorDefault, 1);
}

void get_cf_obj(CFTypeRef* CF_RETURNS_RETAINED result) {
*result = CFArrayCreateMutable(kCFAllocatorDefault, 1);
}

RetainPtr<CFArrayRef> return_arg(CFArrayRef arg) {
return arg;
}
Expand Down