Skip to content

[libc][stdlib] Simplify getenv_test by using strcmp instead of custom helper #163055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2025
Merged

[libc][stdlib] Simplify getenv_test by using strcmp instead of custom helper #163055

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a633655
[libc][stdlib] Simplify getenv_test by using strcmp instead of custom…
kaladron Oct 12, 2025
faa226f
[libc][stdlib] Update getenv_test to use inline_strcmp for string com…
kaladron Nov 13, 2025
8141047
Formatting fixes
kaladron Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 17 additions & 32 deletions libc/test/integration/src/stdlib/getenv_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,43 +7,28 @@
//===----------------------------------------------------------------------===//

#include "src/stdlib/getenv.h"
#include "src/string/memory_utils/inline_strcmp.h"

#include "test/IntegrationTest/test.h"

static bool my_streq(const char *lhs, const char *rhs) {
if (lhs == rhs)
return true;
if (((lhs == static_cast<char *>(nullptr)) &&
(rhs != static_cast<char *>(nullptr))) ||
((lhs != static_cast<char *>(nullptr)) &&
(rhs == static_cast<char *>(nullptr)))) {
return false;
}
const char *l, *r;
for (l = lhs, r = rhs; *l != '\0' && *r != '\0'; ++l, ++r)
if (*l != *r)
return false;

return *l == '\0' && *r == '\0';
}

TEST_MAIN([[maybe_unused]] int argc, [[maybe_unused]] char **argv,
[[maybe_unused]] char **envp) {
ASSERT_TRUE(
my_streq(LIBC_NAMESPACE::getenv(""), static_cast<char *>(nullptr)));
ASSERT_TRUE(
my_streq(LIBC_NAMESPACE::getenv("="), static_cast<char *>(nullptr)));
ASSERT_TRUE(my_streq(LIBC_NAMESPACE::getenv("MISSING ENV VARIABLE"),
static_cast<char *>(nullptr)));
ASSERT_FALSE(
my_streq(LIBC_NAMESPACE::getenv("PATH"), static_cast<char *>(nullptr)));
ASSERT_TRUE(my_streq(LIBC_NAMESPACE::getenv("FRANCE"), "Paris"));
ASSERT_FALSE(my_streq(LIBC_NAMESPACE::getenv("FRANCE"), "Berlin"));
ASSERT_TRUE(my_streq(LIBC_NAMESPACE::getenv("GERMANY"), "Berlin"));
ASSERT_TRUE(
my_streq(LIBC_NAMESPACE::getenv("FRANC"), static_cast<char *>(nullptr)));
ASSERT_TRUE(my_streq(LIBC_NAMESPACE::getenv("FRANCE1"),
static_cast<char *>(nullptr)));
auto comp = [](char l, char r) -> int { return l - r; };
ASSERT_TRUE(LIBC_NAMESPACE::getenv("") == nullptr);
ASSERT_TRUE(LIBC_NAMESPACE::getenv("=") == nullptr);
ASSERT_TRUE(LIBC_NAMESPACE::getenv("MISSING ENV VARIABLE") == nullptr);
ASSERT_FALSE(LIBC_NAMESPACE::getenv("PATH") == nullptr);
ASSERT_EQ(LIBC_NAMESPACE::inline_strcmp(LIBC_NAMESPACE::getenv("FRANCE"),
"Paris", comp),
0);
ASSERT_NE(LIBC_NAMESPACE::inline_strcmp(LIBC_NAMESPACE::getenv("FRANCE"),
"Berlin", comp),
0);
ASSERT_EQ(LIBC_NAMESPACE::inline_strcmp(LIBC_NAMESPACE::getenv("GERMANY"),
"Berlin", comp),
0);
ASSERT_TRUE(LIBC_NAMESPACE::getenv("FRANC") == nullptr);
ASSERT_TRUE(LIBC_NAMESPACE::getenv("FRANCE1") == nullptr);

return 0;
}
Loading