[compiler-rt] [CMake] Skip find_darwin_sdk_dir on disabled platforms #163591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find_darwin_sdk_dir can be slow, especially if xcrun does not immediately find the corresponding SDK (i.e. because it is missing). This skips those checks if the user has already set the corresponding CMake variable to disable the platform anyway.
DanBlackwell
approved these changes
Oct 21, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/15572 Here is the relevant piece of the build log for the reference |
|
Failure does not look related |
|
This was a duplicate of #161877. I'll close that PR. |
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
…lvm#163591) find_darwin_sdk_dir can be slow, especially if xcrun does not immediately find the corresponding SDK (i.e. because it is missing). This skips those checks if the user has already set the corresponding CMake variable to disable the platform anyway.
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
…lvm#163591) find_darwin_sdk_dir can be slow, especially if xcrun does not immediately find the corresponding SDK (i.e. because it is missing). This skips those checks if the user has already set the corresponding CMake variable to disable the platform anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_darwin_sdk_dir can be slow, especially if xcrun does not immediately find the corresponding SDK (i.e. because it is missing).
This skips those checks if the user has already set the corresponding CMake variable to disable the platform anyway.