Skip to content

[TableGen][RISCV] Don't use auto where the type isn't obvious. NFC #163611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

[TableGen][RISCV] Don't use auto where the type isn't obvious. NFC #163611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions llvm/utils/TableGen/Basic/RISCVTargetDefEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,14 @@ static void emitRISCVExtensions(const RecordKeeper &Records, raw_ostream &OS) {
if (!Extensions.empty()) {
OS << "\nstatic constexpr ImpliedExtsEntry ImpliedExts[] = {\n";
for (const Record *Ext : Extensions) {
auto ImpliesList = Ext->getValueAsListOfDefs("Implies");
std::vector<const Record *> ImpliesList =
Ext->getValueAsListOfDefs("Implies");
if (ImpliesList.empty())
continue;

StringRef Name = getExtensionName(Ext);

for (auto *ImpliedExt : ImpliesList) {
for (const Record *ImpliedExt : ImpliesList) {
if (!ImpliedExt->isSubClassOf("RISCVExtension"))
continue;

Expand Down Expand Up @@ -150,11 +151,12 @@ static void emitRISCVProfiles(const RecordKeeper &Records, raw_ostream &OS) {
OS << "#ifdef GET_SUPPORTED_PROFILES\n";
OS << "#undef GET_SUPPORTED_PROFILES\n\n";

auto Profiles = Records.getAllDerivedDefinitionsIfDefined("RISCVProfile");
ArrayRef<const Record *> Profiles =
Records.getAllDerivedDefinitionsIfDefined("RISCVProfile");

if (!Profiles.empty()) {
printProfileTable(OS, Profiles, /*Experimental=*/false);
bool HasExperimentalProfiles = any_of(Profiles, [&](auto &Rec) {
bool HasExperimentalProfiles = any_of(Profiles, [&](const Record *Rec) {
return Rec->getValueAsBit("Experimental");
});
if (HasExperimentalProfiles)
Expand All @@ -173,15 +175,17 @@ static void emitRISCVProcs(const RecordKeeper &RK, raw_ostream &OS) {
// Iterate on all definition records.
for (const Record *Rec :
RK.getAllDerivedDefinitionsIfDefined("RISCVProcessorModel")) {
const std::vector<const Record *> &Features =
std::vector<const Record *> Features =
Rec->getValueAsListOfDefs("Features");
bool FastScalarUnalignedAccess = any_of(Features, [&](auto &Feature) {
return Feature->getValueAsString("Name") == "unaligned-scalar-mem";
});

bool FastVectorUnalignedAccess = any_of(Features, [&](auto &Feature) {
return Feature->getValueAsString("Name") == "unaligned-vector-mem";
});
bool FastScalarUnalignedAccess =
any_of(Features, [&](const Record *Feature) {
return Feature->getValueAsString("Name") == "unaligned-scalar-mem";
});

bool FastVectorUnalignedAccess =
any_of(Features, [&](const Record *Feature) {
return Feature->getValueAsString("Name") == "unaligned-vector-mem";
});

OS << "PROC(" << Rec->getName() << ", {\"" << Rec->getValueAsString("Name")
<< "\"}, {\"";
Expand Down
Loading