[clang][docs] Remove Python2 import handler in dump_ast_matchers.py #163730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM requires Python >=3.8 and in Python 3.0 urllib2 was renamed to urllib. https://docs.python.org/3/whatsnew/3.0.html#library-changes
|
@llvm/pr-subscribers-clang Author: David Spickett (DavidSpickett) ChangesLLVM requires Python >=3.8 and in Python 3.0 urllib2 was renamed to urllib. https://docs.python.org/3/whatsnew/3.0.html#library-changes Full diff: https://github.com/llvm/llvm-project/pull/163730.diff 1 Files Affected:
diff --git a/clang/docs/tools/dump_ast_matchers.py b/clang/docs/tools/dump_ast_matchers.py
index 46b7bb718ba08..5db6826070934 100755
--- a/clang/docs/tools/dump_ast_matchers.py
+++ b/clang/docs/tools/dump_ast_matchers.py
@@ -6,11 +6,8 @@
import collections
import re
import os
+from urllib.request import urlopen
-try:
- from urllib.request import urlopen
-except ImportError:
- from urllib2 import urlopen
CLASS_INDEX_PAGE_URL = "https://clang.llvm.org/doxygen/classes.html"
try:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM requires Python >=3.8 and in Python 3.0 urllib2 was renamed to urllib.
https://docs.python.org/3/whatsnew/3.0.html#library-changes