Skip to content

[NFC][LLVM] Code cleanup in opt #164077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2025
Merged

[NFC][LLVM] Code cleanup in opt #164077

merged 1 commit into from
Oct 20, 2025

Conversation

@jurahul
Copy link
Contributor

@jurahul jurahul commented Oct 18, 2025 •
edited
Loading

  • Use namespace qualifiers to define variables declared in llvm namespace.
  • move file local TimeTracerRAII struct into anonymous namespace.
  • Use explicit types in a few places.
  • Convert the loop over PassList to a range for loop.

@jurahul jurahul marked this pull request as ready for review October 18, 2025 13:18
@jurahul jurahul requested review from arsenm and nico October 18, 2025 13:20
@jurahul jurahul merged commit 39128b9 into llvm:main Oct 20, 2025
13 checks passed
@jurahul jurahul deleted the nfc_cc_opt branch October 20, 2025 16:36
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
@jurahul @Lukacma
[NFC][LLVM] Code cleanup in opt (llvm#164077)
fe925af 
- Use namespace qualifiers to define variables declared in `llvm`
namespace.
- move file local `TimeTracerRAII` struct into anonymous namespace.
- Use explicit types in a few places.
- Convert the loop over `PassList` to a range for loop.
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
@jurahul @aokblast
[NFC][LLVM] Code cleanup in opt (llvm#164077)
ebe3795 
- Use namespace qualifiers to define variables declared in `llvm`
namespace.
- move file local `TimeTracerRAII` struct into anonymous namespace.
- Use explicit types in a few places.
- Convert the loop over `PassList` to a range for loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arsenm arsenm arsenm approved these changes

@nico nico Awaiting requested review from nico

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jurahul @arsenm