Skip to content

[clang] OpenMP: fix variant template mismatch crash #164511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

[clang] OpenMP: fix variant template mismatch crash #164511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clang/lib/Sema/SemaOpenMP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7246,7 +7246,9 @@ void SemaOpenMP::ActOnStartOfFunctionDefinitionInOpenMPDeclareVariantScope(
FunctionDecl *UDecl = nullptr;
if (IsTemplated && isa<FunctionTemplateDecl>(CandidateDecl)) {
auto *FTD = cast<FunctionTemplateDecl>(CandidateDecl);
if (FTD->getTemplateParameters()->size() == TemplateParamLists.size())
// FIXME: Should this compare the template parameter lists on all levels?
if (SemaRef.Context.isSameTemplateParameterList(
FTD->getTemplateParameters(), TemplateParamLists.back()))
UDecl = FTD->getTemplatedDecl();
} else if (!IsTemplated)
UDecl = dyn_cast<FunctionDecl>(CandidateDecl);
Expand Down
12 changes: 12 additions & 0 deletions clang/test/SemaOpenMP/openmp-begin-declare-variant_template.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// RUN: %clang_cc1 -triple x86_64 -fopenmp -verify %s

// FIXME: Is this supposed to work?

#pragma omp begin declare variant match(implementation={extension(allow_templates)})
template <class T> void f(T) {}
// expected-note@-1 {{explicit instantiation refers here}}
#pragma end
template <int> struct A {};
template <bool B> A<B> f() = delete;
template void f<float>(float);
// expected-error@-1 {{explicit instantiation of undefined function template 'f'}}