- 
                Notifications
    
You must be signed in to change notification settings  - Fork 15.1k
 
[clang][x86][bytecode] remove trailing returns type from interp__builtin_elementwise_int_binop callbacks #164679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clang][x86][bytecode] remove trailing returns type from interp__builtin_elementwise_int_binop callbacks #164679
Conversation
| 
          
 @llvm/pr-subscribers-clang Author: don (donneypr) ChangesRegarding the discussion in llvm#162346, this PR is to remove the trailing type from the 'interp__builtin_elementwise_int_unaryop' callbacks. Full diff: https://github.com/llvm/llvm-project/pull/164679.diff 1 Files Affected: 
 diff --git a/clang/lib/AST/ByteCode/InterpBuiltin.cpp b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
index ff83c52b0c8f6..2d5ad4a7a92cf 100644
--- a/clang/lib/AST/ByteCode/InterpBuiltin.cpp
+++ b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
@@ -3471,7 +3471,7 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call,
   case Builtin::BI_lrotl:
   case Builtin::BI_rotl64:
     return interp__builtin_elementwise_int_binop(
-        S, OpPC, Call, [](const APSInt &Value, const APSInt &Amount) -> APInt {
+        S, OpPC, Call, [](const APSInt &Value, const APSInt &Amount) {
           return Value.rotl(Amount);
         });
 
@@ -3485,7 +3485,7 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call,
   case Builtin::BI_lrotr:
   case Builtin::BI_rotr64:
     return interp__builtin_elementwise_int_binop(
-        S, OpPC, Call, [](const APSInt &Value, const APSInt &Amount) -> APInt {
+        S, OpPC, Call, [](const APSInt &Value, const APSInt &Amount) {
           return Value.rotr(Amount);
         });
 
 | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - cheers
…tin_elementwise_int_binop callbacks (llvm#164679) Related to the discussion in llvm#162346, this PR is to remove the trailing type from the 'interp__builtin_elementwise_int_binop' callbacks.
…tin_elementwise_int_binop callbacks (llvm#164679) Related to the discussion in llvm#162346, this PR is to remove the trailing type from the 'interp__builtin_elementwise_int_binop' callbacks.
…tin_elementwise_int_binop callbacks (llvm#164679) Related to the discussion in llvm#162346, this PR is to remove the trailing type from the 'interp__builtin_elementwise_int_binop' callbacks.
…tin_elementwise_int_binop callbacks (llvm#164679) Related to the discussion in llvm#162346, this PR is to remove the trailing type from the 'interp__builtin_elementwise_int_binop' callbacks.
Related to the discussion in #162346, this PR is to remove the trailing type from the 'interp__builtin_elementwise_int_binop' callbacks.