Skip to content

Fix build failures related to PR #164551 #164962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix build failures related to PR #164551 #164962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe09dc2
Fix build failures related to PR #164551
SahilPatidar Oct 24, 2025
e40b13c
Refactor
SahilPatidar Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ set(LLVM_LINK_COMPONENTS
IRReader
JITLink
Object
ObjectYAML
OrcDebugging
OrcJIT
OrcShared
Expand Down
6 changes: 4 additions & 2 deletions llvm/unittests/ExecutionEngine/Orc/LibraryResolverTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,14 +690,16 @@ TEST_F(LibraryResolverIT, PathResolverFollowsSymlinks) {
// Create a symlink temp -> BaseDir (only if filesystem allows it)
std::string linkName = BaseDir + withext("/link_to_C");
std::string target = lib("C");
::symlink(target.c_str(), linkName.c_str());

if (::symlink(target.c_str(), linkName.c_str()) != 0)
GTEST_SKIP() << "Failed to create symlink: " << strerror(errno);

auto resolved = PResolver->resolve(linkName, EC);
ASSERT_TRUE(resolved.has_value());
EXPECT_FALSE(EC);
EXPECT_EQ(*resolved, target);

::unlink(linkName.c_str()); // cleanup
(void)::unlink(linkName.c_str());
}

TEST_F(LibraryResolverIT, PathResolverCachesResults) {
Expand Down