Skip to content

Conversation

@jroelofs
Copy link
Contributor

... which silently caused the wrong overload to be selected.

... which silently caused the wrong overload to be selected.
@llvmbot
Copy link
Member

llvmbot commented Oct 24, 2025

@llvm/pr-subscribers-backend-aarch64

Author: Jon Roelofs (jroelofs)

Changes

... which silently caused the wrong overload to be selected.


Full diff: https://github.com/llvm/llvm-project/pull/165056.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AArch64/AArch64InstrInfo.cpp (+1-1)
diff --git a/llvm/lib/Target/AArch64/AArch64InstrInfo.cpp b/llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
index d5117da524231..791e9311e581a 100644
--- a/llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
+++ b/llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
@@ -122,7 +122,7 @@ unsigned AArch64InstrInfo::getInstSizeInBytes(const MachineInstr &MI) const {
     NumBytes = Desc.getSize() ? Desc.getSize() : 4;
 
     const auto *MFI = MF->getInfo<AArch64FunctionInfo>();
-    if (!MFI->shouldSignReturnAddress(MF))
+    if (!MFI->shouldSignReturnAddress(*MF))
       return NumBytes;
 
     const auto &STI = MF->getSubtarget<AArch64Subtarget>();

Copy link
Contributor

@ojhunt ojhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implicit pointer conversion remains a curse :-O

@jroelofs jroelofs merged commit 9d1b6ee into llvm:main Oct 29, 2025
12 checks passed
@jroelofs jroelofs deleted the jroelofs/pac-ptr-to-bool branch October 29, 2025 19:48
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
... which silently caused the wrong overload to be selected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants