[aarch64][PAC] Move MachO (pro|epi)logue PAC to generic AArch64PointerAuth infra #11713
+89
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... which silently caused the wrong overload to be selected.
jroelofs
force-pushed
the
jroelofs/pac-prologue-epilogue
branch
from
a1c4480 to
b91363d
Compare
jroelofs
commented
Oct 27, 2025
| }); | ||
|
|
||
| // FIXME: do we need to look for the AArch64::RET_POPLESS at the end of the | ||
| // epilogue? |
There was a problem hiding this comment.
This is a question for @ahmedbougacha. I wasn't sure if CC::SwiftCoro == "is RET_POPLESS the last instruction of the epilogue" or if there's a subtle difference there.
jroelofs
force-pushed
the
jroelofs/pac-prologue-epilogue
branch
from
b91363d to
a094df4
Compare
jroelofs
commented
Oct 27, 2025
| ; CHECK-NEXT: ldp x29, x30, [x29] ; 16-byte Folded Reload | ||
| ; CHECK-NEXT: autib x30, x16 | ||
| ; CHECK-NEXT: ret | ||
| ; CHECK-NEXT: retab |
There was a problem hiding this comment.
IIUC this is an improvement, but please double-check me here @ahmedbougacha
…rAuth infra This is _almost_ NFCI, though there are some small changes I expect re: adding cfi's that we were missing before, as well as some small improvements to epilogue sequences in a couple of cases. rdar://163365479
jroelofs
force-pushed
the
jroelofs/pac-prologue-epilogue
branch
from
a094df4 to
a2d29c9
Compare
jroelofs
commented
Oct 27, 2025
| return MFIa->shouldSignReturnAddress(*a.getMF(), false) == | ||
| MFIb->shouldSignReturnAddress(*b.getMF(), false) && | ||
| MFIa->shouldSignReturnAddress(*a.getMF(), true) == | ||
| MFIb->shouldSignReturnAddress(*b.getMF(), true); |
There was a problem hiding this comment.
@dtellenbach I think you had some question about this bit....?
|
This builds on top of llvm#165056 |
|
@swift-ci test llvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost NFCI, though there are some small changes I expect re: adding cfi's that we were missing before, as well as some small improvements to epilogue sequences in a couple of cases.
rdar://163365479