[MemProf] Make Test work with Internal Shell #165146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7
|
@llvm/pr-subscribers-pgo Author: Aiden Grossman (boomanaiden154) ChangesThere is one test that uses a subshell to generate a long path name. Full diff: https://github.com/llvm/llvm-project/pull/165146.diff 1 Files Affected:
diff --git a/compiler-rt/test/memprof/TestCases/log_path_test.cpp b/compiler-rt/test/memprof/TestCases/log_path_test.cpp
index 664ab79393195..683ca67122c31 100644
--- a/compiler-rt/test/memprof/TestCases/log_path_test.cpp
+++ b/compiler-rt/test/memprof/TestCases/log_path_test.cpp
@@ -18,7 +18,8 @@
// RUN: %env_memprof_opts=print_text=true:log_path=/dev/null/INVALID not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-BAD-DIR --dump-input=always
// Too long log_path.
-// RUN: %env_memprof_opts=print_text=true:log_path=`for((i=0;i<10000;i++)); do echo -n $i; done` \
+// RUN: %python -c "for i in range(0, 10000): print(i, end='')" > %t.long_log_path
+// RUN: %env_memprof_opts=print_text=true:log_path=%{readfile:%t.long_log_path} \
// RUN: not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-LONG --dump-input=always
// Specifying the log name via the __memprof_profile_filename variable.
|
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 26, 2025
There is one test that uses a subshell to generate a long path name. Replace it with a python invocation and a readfile substitution. This helps move compiler-rt over to lit's internal shell. Pull Request: llvm#165146
teresajohnson
approved these changes
Oct 26, 2025
fmayer
approved these changes
Oct 27, 2025
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 30, 2025
There is one test that uses a subshell to generate a long path name. Replace it with a python invocation and a readfile substitution. This helps move compiler-rt over to lit's internal shell. Pull Request: llvm#165146
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 30, 2025
There is one test that uses a subshell to generate a long path name. Replace it with a python invocation and a readfile substitution. This helps move compiler-rt over to lit's internal shell. Pull Request: llvm#165146
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 30, 2025
There is one test that uses a subshell to generate a long path name. Replace it with a python invocation and a readfile substitution. This helps move compiler-rt over to lit's internal shell. Pull Request: llvm#165146
boomanaiden154
changed the base branch from
users/boomanaiden154/main.memprof-make-test-work-with-internal-shell
to
main
boomanaiden154
deleted the
users/boomanaiden154/memprof-make-test-work-with-internal-shell
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 30, 2025
There is one test that uses a subshell to generate a long path name. Replace it with a python invocation and a readfile substitution. This helps move compiler-rt over to lit's internal shell. Reviewers: fmayer, snehasish, teresajohnson Reviewed By: fmayer, teresajohnson Pull Request: llvm/llvm-project#165146
luciechoi
pushed a commit
to luciechoi/llvm-project
that referenced
this pull request
Nov 1, 2025
There is one test that uses a subshell to generate a long path name. Replace it with a python invocation and a readfile substitution. This helps move compiler-rt over to lit's internal shell. Reviewers: fmayer, snehasish, teresajohnson Reviewed By: fmayer, teresajohnson Pull Request: llvm#165146
DEBADRIBASAK
pushed a commit
to DEBADRIBASAK/llvm-project
that referenced
this pull request
Nov 3, 2025
There is one test that uses a subshell to generate a long path name. Replace it with a python invocation and a readfile substitution. This helps move compiler-rt over to lit's internal shell. Reviewers: fmayer, snehasish, teresajohnson Reviewed By: fmayer, teresajohnson Pull Request: llvm#165146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one test that uses a subshell to generate a long path name.
Replace it with a python invocation and a readfile substitution. This
helps move compiler-rt over to lit's internal shell.