[Clang] Drop Shell Requirements #165149
Merged
[Clang] Drop Shell Requirements #165149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are basically synonymous with marking windows as an unsupported platform at this point and should be removed in favor of such annotations. Removing the remianing annotations which should further unblock removing the feature altogether now that everything minus compiler-rt is using the internal shell by default.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Aiden Grossman (boomanaiden154) ChangesThese are basically synonymous with marking windows as an unsupported platform at this point and should be removed in favor of such annotations. Removing the remianing annotations which should further unblock removing the feature altogether now that everything minus compiler-rt is using the internal shell by default. These were missed when making the tests compatible with the internal shell. Full diff: https://github.com/llvm/llvm-project/pull/165149.diff 4 Files Affected:
diff --git a/clang/test/ClangScanDeps/resource_directory.c b/clang/test/ClangScanDeps/resource_directory.c
index 6183e8aefacfa..e86f28e77e7c3 100644
--- a/clang/test/ClangScanDeps/resource_directory.c
+++ b/clang/test/ClangScanDeps/resource_directory.c
@@ -1,5 +1,3 @@
-// REQUIRES: shell
-
// RUN: rm -rf %t && mkdir %t
// RUN: cp %S/Inputs/resource_directory/* %t
diff --git a/clang/test/Driver/baremetal-multilib-custom-error.yaml b/clang/test/Driver/baremetal-multilib-custom-error.yaml
index 0be92e26aae28..bc06ed468572c 100644
--- a/clang/test/Driver/baremetal-multilib-custom-error.yaml
+++ b/clang/test/Driver/baremetal-multilib-custom-error.yaml
@@ -1,4 +1,3 @@
-# REQUIRES: shell
# UNSUPPORTED: system-windows
# RUN: %clang --multi-lib-config=%s -no-canonical-prefixes -print-multi-directory 2>&1 \
diff --git a/clang/test/Frontend/absolute-paths-symlinks.c b/clang/test/Frontend/absolute-paths-symlinks.c
index 8170910b6f6ec..80bca34eb9d4b 100644
--- a/clang/test/Frontend/absolute-paths-symlinks.c
+++ b/clang/test/Frontend/absolute-paths-symlinks.c
@@ -12,6 +12,5 @@
// CHECK-SAME: error: unknown type name
This do not compile
-// REQUIRES: shell
// Don't make symlinks on Windows.
// UNSUPPORTED: system-windows
diff --git a/clang/test/Tooling/clang-check-pwd.cpp b/clang/test/Tooling/clang-check-pwd.cpp
index 309cee54aadd9..e4360c006cd16 100644
--- a/clang/test/Tooling/clang-check-pwd.cpp
+++ b/clang/test/Tooling/clang-check-pwd.cpp
@@ -12,5 +12,3 @@
// CHECK: a type specifier is required
// CHECK: .foobar/test.cpp
invalid;
-
-// REQUIRES: shell
|
carlocab
approved these changes
Oct 26, 2025
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/24543 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/15002 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/42/builds/6700 Here is the relevant piece of the build log for the reference |
varun-r-mallya
pushed a commit
to varun-r-mallya/llvm-project
that referenced
this pull request
Oct 27, 2025
These are basically synonymous with marking windows as an unsupported platform at this point and should be removed in favor of such annotations. Removing the remianing annotations which should further unblock removing the feature altogether now that everything minus compiler-rt is using the internal shell by default. These were missed when making the tests compatible with the internal shell.
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
These are basically synonymous with marking windows as an unsupported platform at this point and should be removed in favor of such annotations. Removing the remianing annotations which should further unblock removing the feature altogether now that everything minus compiler-rt is using the internal shell by default. These were missed when making the tests compatible with the internal shell.
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
These are basically synonymous with marking windows as an unsupported platform at this point and should be removed in favor of such annotations. Removing the remianing annotations which should further unblock removing the feature altogether now that everything minus compiler-rt is using the internal shell by default. These were missed when making the tests compatible with the internal shell.
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
These are basically synonymous with marking windows as an unsupported platform at this point and should be removed in favor of such annotations. Removing the remianing annotations which should further unblock removing the feature altogether now that everything minus compiler-rt is using the internal shell by default. These were missed when making the tests compatible with the internal shell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are basically synonymous with marking windows as an unsupported platform at this point and should be removed in favor of such annotations. Removing the remianing annotations which should further unblock removing the feature altogether now that everything minus compiler-rt is using the internal shell by default. These were missed when making the tests compatible with the internal shell.