Skip to content

Conversation

@jimingham
Copy link
Collaborator

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Oct 27, 2025

@llvm/pr-subscribers-lldb

Author: None (jimingham)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/165318.diff

1 Files Affected:

  • (modified) lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py (+3)
diff --git a/lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py b/lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py
index cff97b822db81..45a59f7839964 100644
--- a/lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py
+++ b/lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py
@@ -20,6 +20,9 @@ class TestDriverWithClosedSTDIO(TestBase):
     # each debug info format.
     NO_DEBUG_INFO_TESTCASE = True
 
+    # Windows doesn't have the fcntl module, so we can't run this
+    # test there.
+    @skipIf(oslist=["windows"])
     def test_run_lldb_and_wait(self):
         """This test forks, closes the stdio channels and exec's lldb.
         Then it waits for it to exit and asserts it did that successfully"""

@jimingham
Copy link
Collaborator Author

The x86_64 linux bot succeeded, and the aarch64 failure was a failure to even get the test run started. Since this is fixing a test failure on the Windows bot, I'm going to push this now rather than waiting for another aarch64 Linux run.

@jimingham jimingham merged commit 7a7237b into llvm:main Oct 27, 2025
9 of 10 checks passed
@jimingham jimingham deleted the no-fcntl-on-windows branch October 27, 2025 22:43
DavidSpickett added a commit that referenced this pull request Oct 28, 2025
Test added in #164905, skipped by #165318, but that change did not
guard the import. This import is run when we parse the file which
happens before any skips are applied.
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
Test added in llvm#164905, skipped by llvm#165318, but that change did not
guard the import. This import is run when we parse the file which
happens before any skips are applied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants