release/21.x: [clang-shlib] Fix linking libclang-cpp on Haiku (#156401) #165638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@DavidSpickett What do you think about merging this PR to the release branch? |
Member
Author
|
@llvm/pr-subscribers-clang Author: None (llvmbot) ChangesBackport 21bcd00 Requested by: @brad0 Full diff: https://github.com/llvm/llvm-project/pull/165638.diff 1 Files Affected:
diff --git a/clang/tools/clang-shlib/CMakeLists.txt b/clang/tools/clang-shlib/CMakeLists.txt
index 945076e1ad810..a4d0aa5779a7e 100644
--- a/clang/tools/clang-shlib/CMakeLists.txt
+++ b/clang/tools/clang-shlib/CMakeLists.txt
@@ -41,6 +41,10 @@ if (CLANG_LINK_CLANG_DYLIB)
set(INSTALL_WITH_TOOLCHAIN INSTALL_WITH_TOOLCHAIN)
endif()
+if (HAIKU)
+ list(APPEND _DEPS network)
+endif()
+
add_clang_library(clang-cpp
SHARED
${INSTALL_WITH_TOOLCHAIN}
|
DavidSpickett
approved these changes
Oct 30, 2025
Collaborator
DavidSpickett
left a comment
DavidSpickett
left a comment
There was a problem hiding this comment.
I approve of backporting this. Fixes the build on Haiku, does not impact anyone else.
Haiku requires linking in libnetwork. Co-authored-by: Jérôme Duval <jerome.duval@gmail.com> (cherry picked from commit 21bcd00)
github-project-automation
bot
moved this from Needs Merge
to Done
in LLVM Release Status
|
@brad0 (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 21bcd00
Requested by: @brad0