Skip to content

[lld][macho] Ignore cstrings in bp orderer #165757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

[lld][macho] Ignore cstrings in bp orderer #165757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lld/MachO/BPSectionOrderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ DenseMap<const InputSection *, int> lld::macho::runBalancedPartitioning(
auto *isec = subsec.isec;
if (!isec || isec->data.empty() || !isec->data.data())
continue;
// CString section order is handled by
// {Deduplicated}CStringSection::finalizeContents()
if (isa<CStringInputSection>(isec) || isec->isFinal)
continue;
// ConcatInputSections are entirely live or dead, so the offset is
// irrelevant.
if (isa<ConcatInputSection>(isec) && !isec->isLive(0))
Expand Down
5 changes: 5 additions & 0 deletions lld/test/MachO/bp-section-orderer.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,11 @@ r3:
r4:
.quad s2

# cstrings are ignored by runBalancedPartitioning()
.cstring
cstr:
.asciz "this is cstr"

.bss
bss0:
.zero 10
Expand Down