Skip to content

[libc] Fix strftime_test #165770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

[libc] Fix strftime_test #165770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions libc/test/src/time/strftime_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2329,20 +2329,21 @@ TEST(LlvmLibcStrftimeTest, TimeFormatFullDateTime) {

TEST(LlvmLibcStrftimeTest, BufferTooSmall) {
struct tm time;
char buffer[1];
char tiny_buffer[1];

time.tm_year = get_adjusted_year(2025);
time.tm_mon = 10;
time.tm_mday = 24;

size_t written =
LIBC_NAMESPACE::strftime(buffer, sizeof(buffer), "%F", &time);
LIBC_NAMESPACE::strftime(tiny_buffer, sizeof(tiny_buffer), "%F", &time);
EXPECT_EQ(written, size_t{0});

char buffer2[10];
char small_buffer[10];

// The string "2025-11-24" is 10 chars,
// so strftime needs 10 + 1 bytes to write the string and the null terminator.
written = LIBC_NAMESPACE::strftime(buffer, sizeof(buffer2), "%F", &time);
written =
LIBC_NAMESPACE::strftime(small_buffer, sizeof(small_buffer), "%F", &time);
EXPECT_EQ(written, size_t{0});
}
Loading