[NFCI][lldb][test] Add missing <functional> includes #165772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::ref()` is provided in `<functional>` and with recent libc++ changes it no longer seems to be included transitively. Fix by including explicitly.
|
@llvm/pr-subscribers-lldb Author: Raul Tambre (tambry) Changes
Full diff: https://github.com/llvm/llvm-project/pull/165772.diff 2 Files Affected:
diff --git a/lldb/test/Shell/Register/Inputs/x86-multithread-read.cpp b/lldb/test/Shell/Register/Inputs/x86-multithread-read.cpp
index c5f571fc1d2c4..0d2869c0c577c 100644
--- a/lldb/test/Shell/Register/Inputs/x86-multithread-read.cpp
+++ b/lldb/test/Shell/Register/Inputs/x86-multithread-read.cpp
@@ -1,4 +1,5 @@
#include <cstdint>
+#include <functional>
#include <mutex>
#include <thread>
diff --git a/lldb/test/Shell/Register/Inputs/x86-multithread-write.cpp b/lldb/test/Shell/Register/Inputs/x86-multithread-write.cpp
index 320f9e938e5bf..1f4e91acc4c03 100644
--- a/lldb/test/Shell/Register/Inputs/x86-multithread-write.cpp
+++ b/lldb/test/Shell/Register/Inputs/x86-multithread-write.cpp
@@ -1,6 +1,7 @@
#include <cinttypes>
#include <cstdint>
#include <cstdio>
+#include <functional>
#include <mutex>
#include <thread>
|
JDevlieghere
approved these changes
Oct 30, 2025
luciechoi
pushed a commit
to luciechoi/llvm-project
that referenced
this pull request
Nov 1, 2025
`std::ref()` is provided in `<functional>` and with recent libc++ changes it no longer seems to be included transitively. Fix by including explicitly.
DEBADRIBASAK
pushed a commit
to DEBADRIBASAK/llvm-project
that referenced
this pull request
Nov 3, 2025
`std::ref()` is provided in `<functional>` and with recent libc++ changes it no longer seems to be included transitively. Fix by including explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::ref()is provided in<functional>and with recent libc++ changes it no longer seems to be included transitively. Fix by including explicitly.