Skip to content

[clang] Migrate away from a soft-deprecated constructor of APInt (NFC) #166127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

[clang] Migrate away from a soft-deprecated constructor of APInt (NFC) #166127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
614a781
[clang] Migrate away from a soft-deprecated constructor of APInt (NFC)
kazutakahirata Nov 2, 2025
a3c6b80
Address a comment.
kazutakahirata Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions clang/include/clang/AST/APNumericStorage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,8 @@ class APNumericStorage {
llvm::APInt getIntValue() const {
unsigned NumWords = llvm::APInt::getNumWords(BitWidth);
if (NumWords > 1)
return llvm::APInt(BitWidth, NumWords, pVal);
else
return llvm::APInt(BitWidth, VAL);
return llvm::APInt(BitWidth, llvm::ArrayRef(pVal, NumWords));
return llvm::APInt(BitWidth, VAL);
}
void setIntValue(const ASTContext &C, const llvm::APInt &Val);
};
Expand Down
2 changes: 1 addition & 1 deletion clang/include/clang/AST/AbstractBasicReader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ class DataStreamBasicReader : public BasicReaderBase<Impl> {
llvm::SmallVector<uint64_t, 4> data;
for (uint32_t i = 0; i != numWords; ++i)
data.push_back(asImpl().readUInt64());
return llvm::APInt(bitWidth, numWords, &data[0]);
return llvm::APInt(bitWidth, data);
}

llvm::FixedPointSemantics readFixedPointSemantics() {
Expand Down
3 changes: 2 additions & 1 deletion clang/lib/AST/ByteCode/Floating.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ class Floating final {
if (singleWord())
return APFloat(getSemantics(), APInt(BitWidth, Val));
unsigned NumWords = numWords();
return APFloat(getSemantics(), APInt(BitWidth, NumWords, Memory));
return APFloat(getSemantics(),
APInt(BitWidth, llvm::ArrayRef(Memory, NumWords)));
}

public:
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/AST/ByteCode/IntegralAP.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ template <bool Signed> class IntegralAP final {
if (singleWord())
return APInt(BitWidth, Val, Signed);
unsigned NumWords = llvm::APInt::getNumWords(BitWidth);
return llvm::APInt(BitWidth, NumWords, Memory);
return llvm::APInt(BitWidth, llvm::ArrayRef(Memory, NumWords));
}

public:
Expand Down