Skip to content

Fix issues and re-enable tests disabled in PR #165983 (from PR #165360) #166147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2025
Merged

Fix issues and re-enable tests disabled in PR #165983 (from PR #165360) #166147

merged 3 commits into from
Nov 8, 2025
+4 −5

Conversation

@SahilPatidar
Copy link
Contributor

@SahilPatidar SahilPatidar commented Nov 3, 2025 •
edited
Loading

  1. Fixed test setup to correctly create .so/.dylib files in the build directory.
    Previously, the build was happening in the source directory using the same
    input parent path.

  2. Fixed architecture compatibility check in [ORC][LibraryResolver] Fix ensureFilterBuilt assertion failure and concurrency issue. #166510 .

@SahilPatidar SahilPatidar marked this pull request as ready for review November 3, 2025 11:59
vgvassilev
vgvassilev approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev mentioned this pull request Nov 5, 2025
Merged
@SahilPatidar SahilPatidar merged commit 2a3ef05 into llvm:main Nov 8, 2025
10 checks passed
@SahilPatidar SahilPatidar deleted the fix_165983 branch November 8, 2025 04:40
@llvm-ci
Copy link
Collaborator

llvm-ci commented Nov 8, 2025

LLVM Buildbot has detected a new failure on builder ppc64le-mlir-rhel-clang running on ppc64le-mlir-rhel-test while building llvm at step 6 "test-build-check-mlir-build-only-check-mlir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/129/builds/32705

Here is the relevant piece of the build log for the reference 
Step 6 (test-build-check-mlir-build-only-check-mlir) failure: 1200 seconds without output running [b'ninja', b'check-mlir'], attempting to kill
...
PASS: MLIR-Unit :: IR/./MLIRIRTests/0/130 (3630 of 3641)
PASS: MLIR :: mlir-tblgen/rewriter-errors.td (3631 of 3641)
PASS: MLIR :: mlir-tblgen/llvm-intrinsics.td (3632 of 3641)
PASS: MLIR :: Pass/pipeline-options-parsing.mlir (3633 of 3641)
PASS: MLIR-Unit :: Pass/./MLIRPassTests/10/13 (3634 of 3641)
PASS: MLIR-Unit :: Interfaces/./MLIRInterfacesTests/11/22 (3635 of 3641)
PASS: MLIR-Unit :: Interfaces/./MLIRInterfacesTests/13/22 (3636 of 3641)
PASS: MLIR-Unit :: Interfaces/./MLIRInterfacesTests/12/22 (3637 of 3641)
PASS: MLIR-Unit :: IR/./MLIRIRTests/39/130 (3638 of 3641)
PASS: MLIR-Unit :: IR/./MLIRIRTests/38/130 (3639 of 3641)
command timed out: 1200 seconds without output running [b'ninja', b'check-mlir'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1668.603154

vinay-deshmukh pushed a commit to vinay-deshmukh/llvm-project that referenced this pull request Nov 8, 2025
@SahilPatidar @vgvassilev @vinay-deshmukh
Fix issues and re-enable tests disabled in PR llvm#165983 (from PR ll…
050447a 
…vm#165360) (llvm#166147)

1. Fixed test setup to correctly create .so/.dylib files in the build
directory.
Previously, the build was happening in the source directory using the
same
   input parent path.

2. Fixed architecture compatibility check in llvm#166510 .

Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vgvassilev vgvassilev vgvassilev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SahilPatidar @llvm-ci @vgvassilev