Skip to content

[ADT] Deprecate a soft-deprecated APInt constructor #166314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
Merged

[ADT] Deprecate a soft-deprecated APInt constructor #166314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5add8b
[ADT] Deprecate a soft-deprecated APInt constructor
kazutakahirata Sep 2, 2025
b67824e
Address a comment.
kazutakahirata Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lldb/source/Utility/RegisterValue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ Status RegisterValue::SetValueFromData(const RegisterInfo &reg_info,
int128.x[0] = data2;
int128.x[1] = data1;
}
SetUInt128(llvm::APInt(128, 2, int128.x));
SetUInt128(llvm::APInt(128, int128.x));
}
break;
case eEncodingIEEE754:
Expand Down Expand Up @@ -596,8 +596,10 @@ llvm::APInt RegisterValue::GetAsUInt128(const llvm::APInt &fail_value,
case 8:
case 16:
return llvm::APInt(
BITWIDTH_INT128, NUM_OF_WORDS_INT128,
(reinterpret_cast<const type128 *>(buffer.bytes.data()))->x);
BITWIDTH_INT128,
llvm::ArrayRef(
(reinterpret_cast<const type128 *>(buffer.bytes.data()))->x,
NUM_OF_WORDS_INT128));
}
} break;
}
Expand Down
1 change: 1 addition & 0 deletions llvm/include/llvm/ADT/APInt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ class [[nodiscard]] APInt {
/// Once all uses of this constructor are migrated to other constructors,
/// consider marking this overload ""= delete" to prevent calls from being
/// incorrectly bound to the APInt(unsigned, uint64_t, bool) constructor.
[[deprecated("Use other constructors of APInt")]]
LLVM_ABI APInt(unsigned numBits, unsigned numWords, const uint64_t bigVal[]);

/// Construct an APInt from a string representation.
Expand Down
2 changes: 1 addition & 1 deletion polly/lib/Support/GICHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ APInt polly::APIntFromVal(__isl_take isl_val *Val) {
Data = (uint64_t *)malloc(NumChunks * ChunkSize);
isl_val_get_abs_num_chunks(Val, ChunkSize, Data);
int NumBits = CHAR_BIT * ChunkSize * NumChunks;
APInt A(NumBits, NumChunks, Data);
APInt A(NumBits, ArrayRef(Data, NumChunks));

// As isl provides only an interface to obtain data that describes the
// absolute value of an isl_val, A at this point always contains a positive
Expand Down