[NFC][libclc] Rename clc_cbrt.inc to clc_cbrt.h #166330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__clc_cbrt functions are declared in clc_cbrt.inc. Rename to .h for consistency with other headers.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames clc_cbrt.inc to clc_cbrt.h for consistency with other header files in the libclc project. The change updates include statements to reference the new header file name.
- Updated include statement in
cbrt.clto reference the renamed header - Added include statement in
clc_cbrt.clto properly include the renamed header - Ensures naming consistency across the codebase by using
.hextension for header files
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libclc/opencl/lib/generic/math/cbrt.cl | Updated include path from clc_cbrt.inc to clc_cbrt.h |
| libclc/clc/lib/generic/math/clc_cbrt.cl | Added include for clc_cbrt.h header |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frasercrmck
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__clc_cbrt functions are declared in clc_cbrt.inc. Rename to .h for consistency with other headers.