Skip to content

[libc][math] Refactor the math_errhandling macro definition #166350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2025
Merged

[libc][math] Refactor the math_errhandling macro definition #166350

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1de422d
[libc][math] Refactor the `math_errhandling` macro definition
vhscampos Nov 3, 2025
caf8a66
Add fast math as a condition for errhandling via exceptions
vhscampos Nov 5, 2025
8aa89bf
clang-format
vhscampos Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions libc/include/llvm-libc-macros/math-macros.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,37 @@
#define FP_LLOGBNAN LONG_MAX
#endif

#if defined(__NVPTX__) || defined(__AMDGPU__) || defined(__FAST_MATH__)
#define math_errhandling 0
#elif defined(__NO_MATH_ERRNO__)
#define math_errhandling (MATH_ERREXCEPT)
// Math error handling. Target support is assumed to be existent unless
// explicitly disabled.
#if defined(__NVPTX__) || defined(__AMDGPU__) || defined(__FAST_MATH__) || \
defined(__NO_MATH_ERRNO__)
#define __LIBC_SUPPORTS_MATH_ERRNO 0
#else
#define __LIBC_SUPPORTS_MATH_ERRNO 1
#endif

#if defined(__FAST_MATH__) || \
((defined(__arm__) || defined(_M_ARM) || defined(__thumb__) || \
defined(__aarch64__) || defined(_M_ARM64)) && \
!defined(__ARM_FP))
#define __LIBC_SUPPORTS_MATH_ERREXCEPT 0
#else
#define __LIBC_SUPPORTS_MATH_ERREXCEPT 1
#endif

#if __LIBC_SUPPORTS_MATH_ERRNO && __LIBC_SUPPORTS_MATH_ERREXCEPT
#define math_errhandling (MATH_ERRNO | MATH_ERREXCEPT)
#elif __LIBC_SUPPORTS_MATH_ERRNO
#define math_errhandling (MATH_ERRNO)
#elif __LIBC_SUPPORTS_MATH_ERREXCEPT
#define math_errhandling (MATH_ERREXCEPT)
#else
#define math_errhandling 0
#endif

#undef __LIBC_SUPPORTS_MATH_ERRNO
#undef __LIBC_SUPPORTS_MATH_ERREXCEPT

// POSIX math constants
// https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/math.h.html
#define M_E (__extension__ 0x1.5bf0a8b145769p1)
Expand Down
Loading