Skip to content

[clang-repl] Fix inconsistent flushing between in-process and out-of-process #166368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+22 −0
Open

[clang-repl] Fix inconsistent flushing between in-process and out-of-process #166368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
560ccf4
Fix inconsistent flushing between in-process and out-of-process
anutosh491 Nov 4, 2025
54f577c
Initialize streams to be unbuffered
anutosh491 Nov 6, 2025
181acda
Add tests
anutosh491 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions clang/test/Interpreter/out-of-process.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

extern "C" int printf(const char *, ...);

printf("FLUSH_START");
// CHECK: FLUSH_START
printf("\nFLUSH_OK\n");
// CHECK: FLUSH_OK

int intVar = 0;
double doubleVar = 3.14;
%undo
Expand Down Expand Up @@ -85,4 +90,7 @@ int complexFunc(int x) \
auto r11 = printf("complexFunc(5) = %d\n", complexFunc(5));
// CHECK: complexFunc(5) = 15

printf("FINAL_FLUSH");
// CHECK: FINAL_FLUSH

%quit
14 changes: 14 additions & 0 deletions clang/tools/clang-repl/ClangRepl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,20 @@ int main(int argc, const char **argv) {
Interp = ExitOnErr(clang::Interpreter::create(std::move(CI), Config));
}

if (Config.IsOutOfProcess) {
Copy link
Contributor

@Vipul-Cariappa Vipul-Cariappa Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we condition this on out-of-process?
I am not sure, asking for an opinion.

I guess I am fine with everything else.

Copy link
Member Author

@anutosh491 anutosh491 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, removing the condition would introduce some consistency (otherwise oop is maintaining 1 more PTU .... PTU#2 after the inital runtime).

static const char *const InitUnbufferedStreams = R"(
#include <stdio.h>
__attribute__((constructor))
static void __clang_repl_ioinit(void) {
setvbuf(stdout, NULL, _IONBF, 0);
setvbuf(stderr, NULL, _IONBF, 0);
}
)";

if (auto Err = Interp->ParseAndExecute(InitUnbufferedStreams))
llvm::logAllUnhandledErrors(std::move(Err), llvm::errs(), "error: ");
}

bool HasError = false;

for (const std::string &input : OptInputs) {
Expand Down
Loading