Skip to content

Conversation

@mgcarrasco
Copy link
Contributor

This fixes a typo introduced in #165606 which makes the test case fail.

@mgcarrasco mgcarrasco self-assigned this Nov 4, 2025
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Nov 4, 2025
@mgcarrasco mgcarrasco requested a review from jhuber6 November 4, 2025 15:54
@llvmbot
Copy link
Member

llvmbot commented Nov 4, 2025

@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-clang

Author: Manuel Carrasco (mgcarrasco)

Changes

This fixes a typo introduced in #165606 which makes the test case fail.


Full diff: https://github.com/llvm/llvm-project/pull/166392.diff

1 Files Affected:

  • (modified) clang/test/Driver/hip-spirv-translator-new-driver.c (+1-1)
diff --git a/clang/test/Driver/hip-spirv-translator-new-driver.c b/clang/test/Driver/hip-spirv-translator-new-driver.c
index 315a74635b9b3..979fce5b8bbe3 100644
--- a/clang/test/Driver/hip-spirv-translator-new-driver.c
+++ b/clang/test/Driver/hip-spirv-translator-new-driver.c
@@ -2,7 +2,7 @@
 // The input and output files cannot be the same.
 
 // RUN: %clang --offload-new-driver -### -save-temps -nogpuinc -nogpulib \
-// RUN: --offload-arch=amdgcnspirv -x hip %s 2>&1 \
+// RUN: --target=x86_64-linux-gnu --offload-arch=amdgcnspirv -x hip %s 2>&1 \
 // RUN: | FileCheck %s
 
 // CHECK-NOT: {{".*clang-linker-wrapper.*"}} {{.*}} "-o" "[[OUTPUT_FILE:.*.o]]" {{.*}}"[[OUTPUT_FILE]]"

@jhuber6 jhuber6 enabled auto-merge (squash) November 4, 2025 15:55
@mgcarrasco mgcarrasco force-pushed the macarras/pr/fix-crash-new-offload-driver-test branch from af7c8fb to d5cf7ce Compare November 4, 2025 15:56
@jhuber6 jhuber6 merged commit a50d036 into llvm:main Nov 4, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants