[AMDGPU][MC] Disallow nogds in ds_gws_* instructions #166438
+195
−0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,38 @@ | ||||||
| // RUN: not llvm-mc -triple=amdgcn -mcpu=gfx1010 -mattr=+wavefrontsize32 %s 2>&1 | FileCheck --implicit-check-not=error: %s | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
Contributor
Author
There was a problem hiding this comment. Some instructions all "nogds", e.g., ds_add_u32. When "nogds" is given, the gds bit is cleared. However, the printer does not print "nogds". |
||||||
| // RUN: not llvm-mc -triple=amdgcn -mcpu=gfx1010 -mattr=+wavefrontsize64 %s 2>&1 | FileCheck --implicit-check-not=error: %s | ||||||
|
|
||||||
| ds_gws_sema_release_all nogds | ||||||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||||||
|
|
||||||
| ds_gws_sema_release_all offset:4660 nogds | ||||||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||||||
|
|
||||||
| ds_gws_init v0 nogds | ||||||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||||||
|
|
||||||
| ds_gws_init v0 offset:0 nogds | ||||||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||||||
|
|
||||||
| ds_gws_sema_v nogds | ||||||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||||||
|
|
||||||
| ds_gws_sema_v offset:65535 nogds | ||||||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||||||
|
|
||||||
| ds_gws_sema_br v0 nogds | ||||||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||||||
|
|
||||||
| ds_gws_sema_br v0 offset:4660 nogds | ||||||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||||||
|
|
||||||
| ds_gws_sema_p nogds | ||||||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||||||
|
|
||||||
| ds_gws_sema_p offset:0 nogds | ||||||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||||||
|
|
||||||
| ds_gws_barrier v0 nogds | ||||||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||||||
|
|
||||||
| ds_gws_barrier v0 offset:0 nogds | ||||||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // RUN: not llvm-mc -triple=amdgcn -mcpu=gfx1100 %s 2>&1 | FileCheck --implicit-check-not=error: %s | ||
|
|
||
| ds_gws_barrier v1 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_barrier v1 offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_init v1 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_init v1 offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_br v1 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_br v1 offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_p nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_p offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_release_all nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_release_all offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_v nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_v offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // RUN: not llvm-mc -triple=amdgcn -mcpu=bonaire %s 2>&1 | FileCheck --implicit-check-not=error: %s | ||
|
|
||
| ds_gws_sema_release_all offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_release_all nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_init v1 offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_init v1 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_v offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_v nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_br v1 offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_br v1 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_p offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_p nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_barrier v255 offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_barrier v1 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // RUN: not llvm-mc -triple=amdgcn -mcpu=tonga %s 2>&1 | FileCheck --implicit-check-not=error: %s | ||
|
|
||
| ds_gws_sema_release_all offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_release_all nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_init v1 offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_init v1 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_v offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_v nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_br v1 offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_br v1 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_p offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_p nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_barrier v255 offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_barrier v1 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // RUN: not llvm-mc -triple=amdgcn -mcpu=gfx900 %s 2>&1 | FileCheck --implicit-check-not=error: %s | ||
|
|
||
| ds_gws_sema_release_all offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_release_all nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_init v1 offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_init v1 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_v offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_v nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_br v1 offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_br v1 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_p offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_sema_p nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_barrier v1 offset:65535 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed | ||
|
|
||
| ds_gws_barrier v1 nogds | ||
| // CHECK: :[[@LINE-1]]:{{[0-9]+}}: error: nogds is not allowed |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did the "no" parse in the first place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMDGPUAsmParser::parseCustomOperand()callsparseNamedBit()to parse operands such as "gds". Both "gds" and "nogds" are parsed in the latter, and both ends up as anAMDGPUAsmParser::Immediate. The only difference is "gds" has the value 1 while "nogds" 0.