[MISched][NFC] Rename isUnbufferedGroup to isReservedGroup #166439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both ScheduleDAGInstrs and MachineScheduler, we call
BufferSize = 0as reserved andBufferSize = 1as unbuffered. This convention is stem from the fact that we setSUnit::hasReservedResourceto true when any of the SUnit's consumed resources has BufferSize equal to zero; setSUnit::isUnbufferedto true when any of its consumed resources has BufferSize equal to one.However,
SchedBoundary::isUnbufferedGroupdoesn't really follow this convention: it returns true when the resource in question is aProcResGroupand its BufferSize equals to zero rather than one. This could be really confusing for the reader. This patch renames this function toisReservedGroupin aligned with the convention mentioned above.NFC.