Skip to content

[libc] Allow openat and creat to return fd 0. #166466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

[libc] Allow openat and creat to return fd 0. #166466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce5939a
Allow openat to return fd 0.
jtstogel Nov 4, 2025
98fbfdc
Also allow creat to return a zero file descriptor.
jtstogel Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions libc/src/fcntl/linux/creat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ LLVM_LIBC_FUNCTION(int, creat, (const char *path, int mode_flags)) {
SYS_openat, AT_FDCWD, path, O_CREAT | O_WRONLY | O_TRUNC, mode_flags);
#endif

if (fd > 0)
return fd;

libc_errno = -fd;
return -1;
if (fd < 0) {
libc_errno = -fd;
return -1;
}
return fd;
}

} // namespace LIBC_NAMESPACE_DECL
10 changes: 5 additions & 5 deletions libc/src/fcntl/linux/openat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ LLVM_LIBC_FUNCTION(int, openat, (int dfd, const char *path, int flags, ...)) {

int fd = LIBC_NAMESPACE::syscall_impl<int>(SYS_openat, dfd, path, flags,
mode_flags);
if (fd > 0)
return fd;

libc_errno = -fd;
return -1;
if (fd < 0) {
libc_errno = -fd;
return -1;
}
return fd;
}

} // namespace LIBC_NAMESPACE_DECL
Loading