Skip to content

[BOLT][NFC] Rename funtions with _negative suffix to _unknown when th… #166536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
+15 −15
Merged

[BOLT][NFC] Rename funtions with _negative suffix to _unknown when th… #166536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions bolt/test/runtime/AArch64/inline-memcpy.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,14 @@
# CHECK-ASM: bl{{.*}}<memcpy

# Register move should NOT be inlined (size unknown at compile time)
# CHECK-ASM-LABEL: <test_register_move_negative>:
# CHECK-ASM-LABEL: <test_register_move_unknown>:
# CHECK-ASM: bl{{.*}}<memcpy

# CHECK-ASM-LABEL: <test_x2_rewrite_negative>:
# CHECK-ASM-LABEL: <test_x2_rewrite_unknown>:
# CHECK-ASM: bl{{.*}}<memcpy

# Live-in parameter should NOT be inlined (size unknown at compile time)
# CHECK-ASM-LABEL: <test_live_in_negative>:
# CHECK-ASM-LABEL: <test_live_in_unknown>:
# CHECK-ASM: bl{{.*}}<memcpy

# _memcpy8 should be inlined with end-pointer return (dest+size)
Expand Down Expand Up @@ -262,9 +262,9 @@ test_4_byte_add_immediate:
ret
.size test_4_byte_add_immediate, .-test_4_byte_add_immediate

.globl test_register_move_negative
.type test_register_move_negative,@function
test_register_move_negative:
.globl test_register_move_unknown
.type test_register_move_unknown,@function
test_register_move_unknown:
stp x29, x30, [sp, #-32]!
mov x29, sp
add x1, sp, #16
Expand All @@ -274,20 +274,20 @@ test_register_move_negative:
bl memcpy
ldp x29, x30, [sp], #32
ret
.size test_register_move_negative, .-test_register_move_negative
.size test_register_move_unknown, .-test_register_move_unknown

.globl test_x2_rewrite_negative
.type test_x2_rewrite_negative,@function
test_x2_rewrite_negative:
.globl test_x2_rewrite_unknown
.type test_x2_rewrite_unknown,@function
test_x2_rewrite_unknown:
mov x2, #8
ldr x2, [sp, #24]
bl memcpy
ret
.size test_x2_rewrite_negative, .-test_x2_rewrite_negative
.size test_x2_rewrite_unknown, .-test_x2_rewrite_unknown

.globl test_live_in_negative
.type test_live_in_negative,@function
test_live_in_negative:
.globl test_live_in_unknown
.type test_live_in_unknown,@function
test_live_in_unknown:
# x2 comes in as parameter, no instruction sets it (should NOT inline)
stp x29, x30, [sp, #-32]!
mov x29, sp
Expand All @@ -297,7 +297,7 @@ test_live_in_negative:
bl memcpy
ldp x29, x30, [sp], #32
ret
.size test_live_in_negative, .-test_live_in_negative
.size test_live_in_unknown, .-test_live_in_unknown

.globl test_memcpy8_4_byte
.type test_memcpy8_4_byte,@function
Expand Down
Loading