Skip to content

[MsDemangle] Use NodeList over SmallVector for target names #166586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

[MsDemangle] Use NodeList over SmallVector for target names #166586

merged 1 commit into from
Nov 5, 2025

Conversation

@Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Nov 5, 2025

Using SmallVector would introduce a dependency cycle (see #155630 (comment)), so this uses a NodeList.

@Nerixyz Nerixyz requested a review from zmodem November 5, 2025 16:40
@Nerixyz Nerixyz mentioned this pull request Nov 5, 2025
Merged
zmodem
zmodem approved these changes Nov 5, 2025
View reviewed changes
Copy link
Collaborator

@zmodem zmodem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's unfortunate. This lgtm then.

@Nerixyz Nerixyz enabled auto-merge (squash) November 5, 2025 16:59
@Nerixyz Nerixyz merged commit a1f0fe1 into llvm:main Nov 5, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmodem zmodem zmodem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nerixyz @zmodem